match live update codelab changes and update to use chronometer for c…#375
Conversation
…ountdown Change-Id: Id4766a84292834a9a4ebe5364e804e356397ffa5
alabiaga
requested review from
ashnohe,
madebymozart and
yrezgui
as code owners
Summary of ChangesHello @alabiaga, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the SnackbarNotificationManager to improve the user experience for live order updates. It introduces dynamic countdown timers for delivery and arrival notifications, leveraging the Chronometer feature, and adds brief, critical status texts to various notification stages. These changes align the sample application with the latest codelab guidelines, making the notification system more informative and engaging. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the live update notification sample to use a chronometer for countdowns and adds short critical text to notifications. My review focuses on improving code clarity, correctness, and maintainability. I've identified several hardcoded strings that should be moved to resources for localization. I also found discrepancies and confusing calculations in the chronometer setup, where the code does not match the comments, and I've suggested using TimeUnit for better readability. Lastly, there's a minor formatting issue to address.
2 participants
…ountdown
Change-Id: Id4766a84292834a9a4ebe5364e804e356397ffa5